Peter Cai 3 years ago
parent
commit
f822b989a9

+ 4 - 0
app/src/main/java/im/angry/openeuicc/service/OpenEuiccService.kt

@@ -75,6 +75,7 @@ class OpenEuiccService : EuiccService() {
             }.build()
             }.build()
         }
         }
 
 
+        // TODO: Does isRemovable matter? Will Android even query us for removable SIMs?
         return GetEuiccProfileInfoListResult(RESULT_OK, profiles.toTypedArray(), false)
         return GetEuiccProfileInfoListResult(RESULT_OK, profiles.toTypedArray(), false)
     }
     }
 
 
@@ -106,6 +107,9 @@ class OpenEuiccService : EuiccService() {
         }
         }
     }
     }
 
 
+    // TODO: on some devices we need to update the mapping (and potentially disable a pSIM)
+    //       for eSIM to be usable, in which case we will have to respect forceDeactivateSim.
+    //       This is the same for our custom LUI. Both have to take this into consideration.
     @Deprecated("Deprecated in Java")
     @Deprecated("Deprecated in Java")
     override fun onSwitchToSubscription(
     override fun onSwitchToSubscription(
         slotId: Int,
         slotId: Int,