feat: limits cross profile class enable profile (#253)

Reviewed-on: https://gitea.angry.im/PeterCxy/OpenEUICC/pulls/253
Co-authored-by: septs <github@septs.pw>
Co-committed-by: septs <github@septs.pw>

app-common/src/main/java/im/angry/openeuicc/ui/EuiccManagementFragment.kt

@@ -223,11 +223,8 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
     }
 
     private suspend fun showSwitchFailureText() = withContext(Dispatchers.Main) {
-        Toast.makeText(
-            context,
-            R.string.toast_profile_enable_failed,
-            Toast.LENGTH_LONG
-        ).show()
+        val resId = R.string.toast_profile_enable_failed
+        Toast.makeText(context, resId, Toast.LENGTH_LONG).show()
     }
 
     private fun enableOrDisableProfile(iccid: String, enable: Boolean) {
@@ -238,13 +235,12 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
             ensureEuiccChannelManager()
             euiccChannelManagerService.waitForForegroundTask()
 
-            val err = euiccChannelManagerService.launchProfileSwitchTask(
-                slotId,
-                portId,
-                iccid,
-                enable,
-                reconnectTimeoutMillis = 30 * 1000
-            ).waitDone()
+            val err = euiccChannelManagerService
+                .launchProfileSwitchTask(
+                    slotId, portId, iccid, enable,
+                    reconnectTimeoutMillis = 30 * 1000
+                )
+                .waitDone()
 
             when (err) {
                 null -> {}
@@ -296,17 +292,15 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
 
     protected open fun populatePopupWithProfileActions(popup: PopupMenu, profile: LocalProfileInfo) {
         popup.inflate(R.menu.profile_options)
-        if (profile.isEnabled) {
-            popup.menu.findItem(R.id.enable).isVisible = false
-            popup.menu.findItem(R.id.delete).isVisible = false
-
-            // We hide the disable option by default to avoid "bricking" some cards that won't get
-            // recognized again by the phone's modem. However we don't have that worry if we are
-            // accessing it through a USB card reader, or when the user explicitly opted in
-            if (isUsb || disableSafeguardFlow.value) {
-                popup.menu.findItem(R.id.disable).isVisible = true
-            }
-        }
+        if (!profile.isEnabled) return
+        popup.menu.findItem(R.id.enable).isVisible = false
+        popup.menu.findItem(R.id.delete).isVisible = false
+
+        // We hide the disable option by default to avoid "bricking" some cards that won't get
+        // recognized again by the phone's modem. However we don't have that worry if we are
+        // accessing it through a USB card reader, or when the user explicitly opted in
+        if (!isUsb && !disableSafeguardFlow.value) return
+        popup.menu.findItem(R.id.disable).isVisible = true
     }
 
     sealed class ViewHolder(root: View) : RecyclerView.ViewHolder(root) {
@@ -373,6 +367,7 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
         }
 
         private lateinit var profile: LocalProfileInfo
+        private var canEnable: Boolean = false
 
         fun setProfile(profile: LocalProfileInfo) {
             this.profile = profile
@@ -406,6 +401,13 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
             )
         }
 
+        fun setEnabledProfile(enabledProfile: LocalProfileInfo?) {
+            // cannot cross profile class enable profile
+            // e.g: testing -> operational or operational -> testing
+            canEnable = enabledProfile == null ||
+                    enabledProfile.profileClass == profile.profileClass
+        }
+
         private fun showOptionsMenu() {
             // Prevent users from doing multiple things at once
             if (invalid || swipeRefresh.isRefreshing) return
@@ -420,7 +422,13 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
         private fun onMenuItemClicked(item: MenuItem): Boolean =
             when (item.itemId) {
                 R.id.enable -> {
-                    enableOrDisableProfile(profile.iccid, true)
+                    if (canEnable) {
+                        enableOrDisableProfile(profile.iccid, true)
+                    } else {
+                        val resId = R.string.toast_profile_enable_cross_class
+                        Toast.makeText(requireContext(), resId, Toast.LENGTH_LONG)
+                            .show()
+                    }
                     true
                 }
                 R.id.disable -> {
@@ -471,6 +479,7 @@ open class EuiccManagementFragment : Fragment(), EuiccProfilesChangedListener,
             when (holder) {
                 is ProfileViewHolder -> {
                     holder.setProfile(profiles[position])
+                    holder.setEnabledProfile(profiles.enabled)
                     holder.setProfileSequenceNumber(position + 1)
                 }
                 is FooterViewHolder -> {

app-common/src/main/res/values/strings.xml

@@ -32,6 +32,7 @@
     <string name="profile_switch_did_not_refresh">The operation was successful, but your phone\'s modem refused to refresh. You might need to toggle airplane mode or reboot in order to use the new profile.</string>
 
     <string name="toast_profile_enable_failed">Cannot switch to new eSIM profile.</string>
+    <string name="toast_profile_enable_cross_class">To enable this profile, please first disable the currently enabled profile.</string>
     <string name="toast_profile_delete_confirm_text_mismatched">Confirmation string mismatch</string>
     <string name="toast_euicc_memory_reset_confirm_text_mismatched">Confirmation string mismatch</string>
     <string name="toast_euicc_memory_reset_finitshed">This chip has been erased</string>

app/src/main/java/im/angry/openeuicc/ui/PrivilegedEuiccManagementFragment.kt

@@ -40,13 +40,12 @@ class PrivilegedEuiccManagementFragment: EuiccManagementFragment() {
 
     override fun populatePopupWithProfileActions(popup: PopupMenu, profile: LocalProfileInfo) {
         super.populatePopupWithProfileActions(popup, profile)
-        if (profile.isEnabled && !isRemovable) {
-            // Only show the disable option for non-removable eUICCs
-            // Some devices without internal eUICCs have the "optimization" of ignoring SIM
-            // slots without a valid profile. This can lead to "bricking" of external eUICCs
-            // at least for that specific device.
-            // TODO: Maybe we can still make this option available in some sort of "advanced" mode.
-            popup.menu.findItem(im.angry.openeuicc.common.R.id.disable).isVisible = true
-        }
+        if (!profile.isEnabled || isRemovable) return
+        // Only show the disable option for non-removable eUICCs
+        // Some devices without internal eUICCs have the "optimization" of ignoring SIM
+        // slots without a valid profile. This can lead to "bricking" of external eUICCs
+        // at least for that specific device.
+        // TODO: Maybe we can still make this option available in some sort of "advanced" mode.
+        popup.menu.findItem(im.angry.openeuicc.common.R.id.disable).isVisible = true
     }
 }